Take 2 on the fixing the code to satisfy the unit tests.
Of course we want to zero out values that don't match our desired mask values, but only in the case when we were explicit about the mask_value to begin with. When mask_value=None (the default case now), we don't do any processing, which should keep the unit tests happy, while not causing the domain to blow up in size because it finds +ve values outside the desired domain (which it never clips out).
Take 2 on the fixing the code to satisfy the unit tests.
Of course we want to zero out values that don't match our desired mask values, but only in the case when we were explicit about the
mask_valueto begin with. Whenmask_value=None(the default case now), we don't do any processing, which should keep the unit tests happy, while not causing the domain to blow up in size because it finds +ve values outside the desired domain (which it never clips out).