search

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.06k stars 173 forks source link

Rewrite AppStream meta data #1812

Closed theGreatWhiteShark closed 1 year ago

theGreatWhiteShark commented 1 year ago

New metadata file with proper license, more information, and a full list of all recent releases including artifacts.

Fixes https://github.com/hydrogen-music/hydrogen/issues/774

trebmuh commented 1 year ago

Hi @theGreatWhiteShark Can you make that translatable in a .po file?

theGreatWhiteShark commented 1 year ago

Can you make that translatable in a .po file?

Yes. I'll look into it.

theGreatWhiteShark commented 1 year ago

@trebmuh I decided to not put the new translations files next to the existing ones in data/i18n but instead to create a new folder linux/po. I did so because the new translations use another toolchain (the one we already use in the documentation) which I don't want to add to the main one. Otherwise building Hydrogen from source would be even more involved for casual programmers or newbies. I hope this does not produce too much overhead for translators.

hfiguiere commented 1 year ago

Also it's unfortunate you changed the app-id. And it's not even consistent with the .desktop file.

(It's Hydrogen with an uppercase, it's case sensitive)

hfiguiere commented 1 year ago

See https://github.com/hydrogen-music/hydrogen/pull/1816 for the fixes.

The files aren't even installed.

theGreatWhiteShark commented 1 year ago

The files aren't even installed.

From what I read in the AppStream documentation the purpose of this file is to allow it to be shown used in software centers by provided distribution-independent meta infos. I thought it is just something a third-party tool is using. Which parts of the OS use this file when compiling and installing it locally?

hfiguiere commented 1 year ago

Applications can ship one or more files in /usr/share/metainfo/%{id}.metainfo.xml.

So yeah it should be installed. The old one is installed. See #1816