hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.03k stars 172 forks source link

Fix segfault on panic button #1824

Closed theGreatWhiteShark closed 1 year ago

theGreatWhiteShark commented 1 year ago

Seems like no one is using the panic button to immediately stop transport as well as audio processing.

Since at least v1.0.0-beta2 the call to Hydrogen::__panic was not guarded by locking the AudioEngine mutex. This lead to segfaults when hitting the panic button while playback was rolling.