hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.03k stars 172 forks source link

Allow Midi Notes up to 127 in Instrument MIDI Output #1828

Closed PatDyn closed 1 year ago

PatDyn commented 1 year ago

Hydrogen version * : 1.2.1-1 Operating system + version : Manjaro, installed via pamac Audio driver + version : Jack, 1.9.22


I've been using hydrogen along with a launch pad mini, using its buttons to mute/unmute instruments in H2. Having the midi note output is incredibly helpful as it visual feedback for the currently playing instruments on the launchpad.

However, this is limited by the cap on the MIDI note number output. That means visual feedback of playing instruments stops in the middle of a row of buttons. Is there any specific reason why there is a limit? Or would it be possible to remove the cap and make all note numbers available for output?


theGreatWhiteShark commented 1 year ago

Is there any specific reason why there is a limit?

No. That's a bug. Thanks for reporting!

theGreatWhiteShark commented 1 year ago

The fix will be part of the 1.2.2 patch release.

If you could check the fix in either the releases/1.2 branch or in the latest developer version on master, this would be great.

PatDyn commented 1 year ago

Thanks! I built from master and everything works as expected.