search

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.03k stars 172 forks source link

NoteOff notes are rendered as regular notes #1854

Closed theGreatWhiteShark closed 10 months ago

theGreatWhiteShark commented 11 months ago

Hydrogen version : 1.2.

This picture from our docs nicely illustrates that the rendering of NoteOff notes is off. It looks exactly like a regular note although it does stop playback instead of triggering it. (such a note can be added by shift + left click)

theGreatWhiteShark commented 11 months ago

Fixed in #1856

theGreatWhiteShark commented 11 months ago

When thinking about this one twice it feels like there is some more work to be done in here. Just making the NoteOff a regular note with a blue color (for backward compatibility) just doesn't cut it. The meaning of a blue colored note is far from being obvious.

Instead, we could render NoteOff notes as x instead of the regular note shape. This more clearly shows its intention and it's probably quite easy to understand for users already using NoteOff notes in previous versions. (Coloring is still done using the same Theme option)