search

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.03k stars 172 forks source link

NoteOff handling is broken #1858

Closed theGreatWhiteShark closed 11 months ago

theGreatWhiteShark commented 11 months ago

Hydrogen version * : 1.2

Having several instruments with notes in a pattern and adding NoteOff / stop notes for each of them does not stop audio rendering at the end of the pattern. (See #1853)

Even more strangely, when (after adding NoteOffs to multiple instruments using Shift + left click) hitting Shift + left click again on e.g. the NoteOff of the first instrument the NoteOff of the other instruments will be removed. But the one you clicked at is still present.

theGreatWhiteShark commented 11 months ago

False positive. The NoteOff notes were located to close to end of the pattern and were not picked up by Hydrogen.