hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.03k stars 172 forks source link

PatternEditor: harmonize custom length & NoteOff #1864

Closed theGreatWhiteShark closed 11 months ago

theGreatWhiteShark commented 11 months ago

The custom length of a note is only drawn till the nearest NoteOff note. As this one stop the audio rendering of the note having the length reaching beyond it is bad.

addresses #1859

Previous UX

noteOffScreenshot

New UX

Create a note with a custom note length

state1

Add a NoteOff (Shift + left click)

state2

Add another NoteOff

state3

Move those NoteOffs to another instrument

state4

and back in.

state5

All these actions can be properly undone.