search

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.03k stars 172 forks source link

fatal error: 'CoreMidi/CoreMidi.h' file not found #1865

Closed ryandesign closed 10 months ago

ryandesign commented 11 months ago

Hydrogen version * : 1.2.2 Operating system + version : macOS (any) Audio driver + version : N/A

CoreMIDI is miscapitalized in the source code, resulting in build failure on case-sensitive filesystems:

hydrogen-1.2.2/src/core/IO/CoreMidiDriver.h:36:10: fatal error: 'CoreMidi/CoreMidi.h' file not found
#include <CoreMidi/CoreMidi.h>
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.
theGreatWhiteShark commented 11 months ago

Hey @ryandesign ,

resulting in build failure on case-sensitive filesystems

Are case-sensitive filesystems something introduced recently to macOS? This include was not touched in 14 years and the build runs smooth in our AppVeyor macOS pipeline.

(Disclaimer: I'm not a macOS person and have not access to it other than our build pipeline)

cme commented 11 months ago

Case sensitive filesystems have always been an option in OSX but the default is for HFS/APFS to be case-insensitive, no it's not surprising this got missed!

Good catch.

theGreatWhiteShark commented 11 months ago

So, the proper version is

#include <CoreMIDI/CoreMIDI.h>

?