Closed iqwoo closed 9 months ago
Hey @iqwoo ,
Are you able to reproduce this crash? I already saw it a couple of times but was not able to consistently reproduce it in order to debug it.
Yes I'm able. It happens everytime I close hydrogen
Enrico
Inviato da Proton Mail mobile
-------- Messaggio originale -------- Il 7 ott 2023, 14:19, theGreatWhiteShark ha scritto:
Hey @.***(https://github.com/iqwoo) ,
Are you able to reproduce this crash? I already saw it a couple of times but was not able to consistently reproduce it in order to debug it.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
Yes I'm able. It happens everytime I close hydrogen
Nice. Can you post your JACK settings? Is this happening with just a particular song and e.g. just when you started playback or every single time including when using the default song?
Sorry for the delay. It's happening on two different system (my desktop and my laptop) with two different USB Audio Device (Behringer XAIR XR18 and Zoom U-44) I use QjackCtl to start Jackd: Those are the settings for U-44 but the ones for XR18 are the same
And this is the content of my .jackrdc file:
/usr/bin/jackd -dalsa -dhw:U44 -r48000 -p1024 -n3 -Xraw -I60 -O60
Hmm... I can't reproduce the crash with your config.
Could you run
jackd --version
Also, could you check this build of Hydrogen? (or alternatively build from source in branch phil-address-1867-artifacts
) I found a bug which could be the cause. But I'm not sure.
Does the crash also occur when restarting the audio driver in the Preferences or just during shutdown? Does it matter whether playback is rolling or other JACK clients are present?
jackdmp version 1.9.22 tmpdir /dev/shm protocol 9
The crash also occurs when I restart the audio driver in preferences. It does not matter if the playback is rolling. It does not matter if other clients are present.
I tried the appimage you sent me and the crash did not happened neither quitting nor restarting the audio driver. Maybe that bus is the cause. I'm curious now, can you explain to me the bug? (I'm not as good as you but I was a developer in industrial automation and I used Qt in the past quite a lot so I think that at least I can understand something)
I tried the appimage you sent me and the crash did not happened neither quitting nor restarting the audio driver.
So, the issue is resolved? Awesome!
I changed the following: The audio engine of Hydrogen was not locked while stopping the driver https://github.com/hydrogen-music/hydrogen/pull/1887/files#diff-1ee5d29336f73a9ef185a2ab6316223cb9dead1b5787e306782239f148b74807L1036 . This means the state of the engine could get into a dirty state while JACK was processing its callback.
These lines were encountered every time the JACK driver was stopped incl. on shutdown or restarting the driver with other parameters. Whether or not this dirty state occurs is depending largely on CPU load and capability. Multicores with lots of idle time and power do spend only a fraction of their time within the callback function. But less powerful systems might be in there most of the time. That might explain why you did encounter the bug every time and I did only very rarely. But why it was crashing instead of just being "dirty"? No idea. Hard to tell without reproducing it. But since its fixed, we are fine :)
Hydrogen version * : 1.2.2 Operating system + version : Archlinux Audio driver + version : Jack
Quitting Hydrgen results in a crash with this output: