search

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.01k stars 172 forks source link

Sampler: trigger note release on custom length #1884

Closed theGreatWhiteShark closed 8 months ago

theGreatWhiteShark commented 9 months ago

custom note lengths are used to trigger the release of a note and the Sampler will play them back till the additional release frames are rendered. Previously, the custom length was used to stop audio rendering of a note creating a pronounced artifact.

From the looks of the code it is very likely that this worked for a long time but was broken just recently. Well, happens. But should not happen again as custom note lengths are now covered by the unit tests and even a tiny tweak on the release knob for the test song should make them fail.

Addresses #1873

theGreatWhiteShark commented 9 months ago

Turns out these patches also fix the rendering issues with active filtering. 🥳