The Song class does now hold a proper Drumkit instead of just an InstrumentList and DrumkitComponents.
First of all, sorry for the massive PR. But without various UX tweaks the change above would had given users installing directly from master a hard time.
Unfortunately, this required changes in the drumkit XSD and .h2song format in such a way kits and songs from >=1.3. won't work in Hydrogen <=1.2.2. But I intend to add forward compatibility to the upcoming 1.2.3 patch release in order to make this transition more smooth.
Internally, this made drumkit handling much more clean and a lot of code acting on the instrument list and components previously located in the song could be moved from the GUI part into Drumkit.
Also, a lot of DrumkitComponent related bugs and inconsistencies have been fixed along the way.
UX changes
Switching drumkits, replace the current kit by a new one, as well as adding, deleting, and renaming drumkit components can now be undone.
Pattern and drumkit properties can be edited by clicking the corresponding name in the left column of the Pattern Editor.
Drumkit handling was reworked. Each song will now hold a proper drumkit. Tweaking its name, instruments etc. does not affect the kits in the Sound Library (user and system drumkit folder) unless it is explicitly saved to it. All actions in the Main Menu > Drumkit only affect the song's kit. All actions in the Sound Library do only affect the selected kit and not the one of the current song (except loading).
Adjustments done in the Sample Editor are now stored in the kit as well (previously, this was only possible in songs).
Highlighting of the last loaded drumkit in the Sound Library as well as the whole concept of "last loaded drumkit" was dropped.
The
Songclass does now hold a properDrumkitinstead of just anInstrumentListandDrumkitComponents.First of all, sorry for the massive PR. But without various UX tweaks the change above would had given users installing directly from
mastera hard time.Unfortunately, this required changes in the drumkit XSD and .h2song format in such a way kits and songs from >=1.3. won't work in Hydrogen <=1.2.2. But I intend to add forward compatibility to the upcoming 1.2.3 patch release in order to make this transition more smooth.
Internally, this made drumkit handling much more clean and a lot of code acting on the instrument list and components previously located in the song could be moved from the GUI part into
Drumkit.Also, a lot of
DrumkitComponentrelated bugs and inconsistencies have been fixed along the way.UX changes
Fixes #1849 Addresses #1213 Addresses #1901