search

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows
http://www.hydrogen-music.org
GNU General Public License v2.0
1.04k stars 172 forks source link

MP3 file support? #2023

Open 7z3m opened 3 weeks ago

7z3m commented 3 weeks ago

Hydrogen version * : 1.2.2 Operating system + version : gentoo linux Audio driver + version : alsa

mp3 files not showing, i only get empty folders when i look for drumkit after clicking on import from the menu. I enabled mp3 and mpgeg use flags. I added the drumkit to /usr/share/hydrogen/data/drumkits and to the home folder hydrogen/data/drumkits and its not showing either.

log messages show (E)Filesystem: is not usable

i compiled hydrogen from the official gentoo repo.

theGreatWhiteShark commented 3 weeks ago

Hey @7z3m ,

Currently Hydrogen does only support MP3 encoded audio due to an upstream limitation. But it should be feasible since the corresponding patents expired.

7z3m commented 3 weeks ago

you mean currently it does not* ? is there an update in the works?

theGreatWhiteShark commented 3 weeks ago

you mean currently it does not* ?

Let's say it does not work properly yet.

In case your system ships libsndfile >= v1.1 (as Gentoo does) the library we use to load sample files did already "healed" itself and Hydrogen is able to load and play MP3 samples. But filters in file dialogs have not been adopt to allow MP3 files yet. You have to manually edit the corresponding .h2song and drumkit.xml file to include them.

is there an update in the works?

Hmm.. Maybe I'm missing something but this seems like a fairly easy patch. I'll look into it soon.

7z3m commented 3 weeks ago

that would be great, maybe post on here the progress so i can get notified? i can give u a lot of mp3 drum kits as a thank you ;)

theGreatWhiteShark commented 3 weeks ago

that would be great, maybe post on here the progress so i can get notified?

Sure

i can give u a lot of mp3 drum kits as a thank you ;)

Awesome :)

7z3m commented 3 weeks ago

im gonna post it here before u close this issue.

i put the sounds i use in the making of each track on my website, its hosted on github.

github.com/kingillmusic/website/static/mp3

www.kingillmusic.com (click on the right side of the track, the arrow pointing down)

theGreatWhiteShark commented 2 weeks ago

i put the sounds i use in the making of each track on my website, its hosted on github.

github.com/kingillmusic/website/static/mp3

www.kingillmusic.com (click on the right side of the track, the arrow pointing down)

Awesome! Nice beats! Thanks for sharing.

theGreatWhiteShark commented 5 days ago

Hey @7z3m ,

Could you check whether MP3 support works properly in this version of Hydrogen?

7z3m commented 2 days ago

its giving me "no such file or directory" when in try to run the appimage. i have fuse enabled in kernel, i compiled libfuse through portage, and i have hydrogen compiled through portage and working just fine, so i don't think its a dependency issue.

theGreatWhiteShark commented 2 days ago

Hmm. Maybe this one helps https://wiki.gentoo.org/wiki/AppImage.

But since you already compiled Hydrogen yourself: the AppImage corresponds to the code in branch phil-fix-libsndfile-additional-formats-2023-artifacts. You could also compile it from there.