Add a icon to the h2 drumkit files for drumkit browser and mixer

hydrogen-music / hydrogen

The advanced drum machine for Linux, macOS, and Windows

http://www.hydrogen-music.org

GNU General Public License v2.0

1.05k stars 173 forks source link

Add a icon to the h2 drumkit files for drumkit browser and mixer #402

Open Reaper10 opened 8 years ago

Reaper10 commented 8 years ago

Add a icon to the h2 drum kit files 1 drum-set-drawing-drum jpeg 2

these could be for the drum kit bowser within Hydrogen

it mite all so be a good idea to have icon for the kit peaces they could all so be used mixer channels labels

this will all so help in better mixer #259

trebmuh commented 8 years ago

I like the idea of having a picture for the drumkits in our files browsers. Some comments/remarks:

the image should be a square rather than rectangular
the background should be transparent (not white)
the image should be recognizable even when small (ie 36 by 36 px as an example)

elpescado commented 8 years ago

I think those images are intended for drumkit browser in Hydrogen, not file icons. File icons would be nice, though.

trebmuh commented 8 years ago

@Reaper10 : could you please give us some more information about what those images are intended to ?

mauser commented 8 years ago

In addition, we need more information about the licences for those images..

mauser commented 8 years ago

I'm closing this issue due to lack of feedback. This can be re-opened anytime if there will be an reply..

Reaper10 commented 7 years ago

those where mockups

trebmuh commented 6 years ago

(reopening since it has been answered and I'm curious about what we are talking about here)

@Reaper10 please, feel free to develop what you're thinking about. I'm still unsure what you're referencing here: are those images are intended for the drumkit browser in Hydrogen, or for file icons.

Reaper10 commented 6 years ago

these could be for the drum kit bowser within Hydrogen

trebmuh commented 6 years ago

I'm pretty sure we already have that since @pvint has been working on it see here and here as well.

@Reaper10 : the feature you asked here looks to be already there to me, or were you asking for something else and I didn't get it maybe?

Reaper10 commented 6 years ago

im talking here

trebmuh commented 6 years ago

I don't understand what you means @Reaper10 .

Would you mind explaining where you expected an image to be displayed here on the list? Please, be as precise as you can to explain yourself and make a mockup since it'll help a lot.

Also, I'd like to ask you to stop changing your first message with adding more things along the way since I feel it doesn't help at all to communicate in a proper way. It makes feeling that you're jumping from an idea to another one every message you're adding to the thread.