hydrogen-sailfishos / harbour-hydrogen

Apache License 2.0
7 stars 8 forks source link

Filtered room is filled with my username when I go back from the page Settings #41

Open antoyo opened 11 months ago

antoyo commented 11 months ago

Hi. The following actions will fill the "Filter rooms..." input text with my username:

I would expect the input text to not be filled.

I don't know if this is an issue with upstream of the SailfishOS port.

Thanks.

b100dian commented 11 months ago

Hi, thank you for your bug report. I recall to have noticed this while at the November hackathon, however I do not see it now, not on my device and nor on https://hydrogen.element.io which also runs 0.4.1 today. Are you able to reproduce it on a desktop browser too?

antoyo commented 11 months ago

No. I cannot reproduce in my desktop browser. Should I try on Firefox or Chrome to mimic most closely the app?

I have hydrogen-sailfishos 0.4.1+master on a Sony Xperia XA2 with SailfishOS version 4.5.0.24.

b100dian commented 11 months ago

I think Firefox with a very narrow window.. But thanks for stating that you're running the latest, I am sure we'll find a way to repro it again - @pherjung maybe you have seen it too? If not, we can check the upstream source. Initial grepping doesn't show much on "room-filter" other than the fact that autocomplete is on. Maybe this happens only in the session you initially log in, and username is retained by the browser?

antoyo commented 11 months ago

The issue doesn't happen in Firefox either. Any other thing I could test?

pherjung commented 11 months ago

Yes, I already noticed this issue. I don't know where is the bug, but if I find something I'll comment here.

yajo10 commented 11 months ago

It suddenly is reproduce able for me now as well.

b100dian commented 11 months ago

Is this with an user name (as in, lowercase etc.) or with a Name (which may have the first letter uppercased)? I ask to determine if there's a name clash with the login field (in which case one should remember if Save password was used) or just an application bug.

pherjung commented 10 months ago

Strangely, I haven't been able to figure out how to reproduce this bug. At the moment it looks really random.

antoyo commented 10 months ago

Is this with an user name (as in, lowercase etc.) or with a Name (which may have the first letter uppercased)? I ask to determine if there's a name clash with the login field (in which case one should remember if Save password was used) or just an application bug.

It's the username (lowercase).

ichthyosaurus commented 1 month ago

I have multiple accounts and in my case it is actually the username (lowercase) of the first account: if my accounts are "jim", "john", "jane", then it is always "jim" no matter which account I used to open the settings page.

ichthyosaurus commented 1 day ago

This is https://github.com/element-hq/hydrogen-web/issues/380. I proposed a fix in https://github.com/element-hq/hydrogen-web/pull/1200.