search

hydrogen-sailfishos / harbour-hydrogen

Apache License 2.0
7 stars 8 forks source link

Voice messages not shown #48

Open ichthyosaurus opened 1 month ago

ichthyosaurus commented 1 month ago

When I receive voice messages / audio attachments, they are not visible in the channel at all. (They do work in Sailtrix...)

I don't really know where to start debugging this.

b100dian commented 1 month ago

I think the first test would be to try logging into hydrogen.element.io and see if they show up there. I did not use audio attachments so maybe it is easier for your.

If you make the window more portrait-ish you should get the mobile interface if I remember correctly.

Now, if you see the audio messages there, it means that the next thing we have to do is to upgrade our https://github.com/hydrogen-sailfishos/hydrogen-web fork to the current version - requires some small build changes and a link click bug fix and I should be able to to that when I have the time

ichthyosaurus commented 1 month ago

I think the first test would be to try logging into hydrogen.element.io and see if they show up there. I did not use audio attachments so maybe it is easier for your.

It doesn't show up there either, at all :/ So that means upstream doesn't support this, right? I'll open a bug report there.

Edit: I opened https://github.com/element-hq/hydrogen-web/issues/1187

ichthyosaurus commented 4 days ago

I kind of fixed this in https://github.com/ichthyosaurus/hydrogen-web/tree/audio-sticker

b100dian commented 3 days ago

I think seeing there is any audio message and then being able to download it is inifinitely better than nothing.

I would encourage you to make a pull request to hydrogen web, they might take a while to look at it but I got a small one in so it is open to contributions.

b100dian commented 3 days ago

Ah, we could package the changes from your fork, but needs some setup. I just skiped our custom build because I could use hydrogen-web from upstream directly since 5.1, there's a PR for that. I'll consider this, thanks!

ichthyosaurus commented 1 day ago

I opened a PR upstream (https://github.com/element-hq/hydrogen-web/pull/1195) but it may make sense to package my fixes manually because upstream appears to move quite slowly.