search

hydrogo / rainnet

RainNet: a convolutional neural network for radar-based precipitation nowcasting
MIT License
118 stars 61 forks source link

RainNet Training Notebook #8

Closed PradyumnaGupta closed 3 years ago

PradyumnaGupta commented 3 years ago

Added a Google Colaboratory Notebook for training RainNet in response to the various issues (#1, #2 ) requesting for a training script. The notebook contains the essential description of the code and the links to download the dataset.

PradyumnaGupta commented 3 years ago

@hydrogo, you need to accept this pull request to add my training code to your repo.

hydrogo commented 3 years ago

Hi @PradyumnaGupta, I am very grateful for your work in providing RainNet's training code in the form of a Colab notebook.

However, I am not sure that I should merge your pull request as is because of two questions that I think should be resolved first:

  1. You put the information about your training code right on top of the README's header. Could you, please, move it to the Section "Optimization procedure?"
  2. I would also ask you to move the .ipynb file to the examples folder. Is it OK?

Again, many thanks for your contribution.

All the best, Georgy

PradyumnaGupta commented 3 years ago

@hydrogo, I have made the changes you suggested.