hydrologie / xhydro

Hydrological analysis library built with xarray.

https://xhydro.readthedocs.io

Apache License 2.0

17 stars 4 forks source link

Fa regional #186

Closed TC-FF closed 3 weeks ago

TC-FF commented 1 month ago

Pull Request Checklist:

[x] Documentation has been added but still needs some formating
[x] Tests have been added.
[x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

This PR add a regional method in frequency analysis module. It also adds some uncertainities done by resampling obs or distribution

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

TC-FF commented 1 month ago

@Zeitsperre doc is not passing. lmoment3 issue. I tried the fix of PMP but when I try to commit GH workflow main.yml I get an error of new line feed not being \n

Zeitsperre commented 1 month ago

@TC-FF Hey there, excuse the delay.

I think the issue you're having is due to a configuration I set in .yamllint.yml. The issue should be resolved if you comment out these two lines:

  new-lines:
    type: unix

TC-FF commented 1 month ago

I was able to ass lmoment3 with your fix @Zeitsperre , but tests are still not passing. They also require lmoment3, so i'm not sure on how to import it

RondeauG commented 3 weeks ago

195 va régler les problèmes.