hydrosolutions / riversCentralAsia

Package with helper functions to load, manage and analyze hydrometeorological data from Central Asia
GNU General Public License v3.0
1 stars 1 forks source link

clarifications/additional details in JOSS paper #112

Closed tonyewong closed 1 year ago

tonyewong commented 1 year ago

https://github.com/openjournals/joss-reviews/issues/4805#issuecomment-1302886413 (text below)

Could a bit more be said in the Summary section of the paper about how this package might be useful in some broader applications, beyond specifically for students? I can appreciate that much of this was developed for a course, but I can also see how this sort of software will be useful for practitioners and researchers, in addition to students.

Then in Statement of Need/Related packages, it isn't immediately clear to me as a non-specialist how RS Minerve and the other mentioned packages fits into this picture in terms of functionality, as compared to the riversCentralAsia package. I was maybe a little confused here because the first part of Related Packages mentions the RSMinverveR package, which it says can run RS Minerve through R. But later this section says "there is no R package to facilitate hydrological modelling specifically with RS Minerve". There is probably a distinction here that I'm not quite getting. Can this part be clarified?

Can the Summary also be expanded slightly to mention that this software takes care of processing many standard data types? I was poking through the documentation site (which is impressive), which makes this clear, particularly on the "Description of data raw types" page. The paper's Summary section could also serve to advertise this feature.

mabesa commented 1 year ago

Thank you for your persistence! I did a minimal update of both the readme in the main branch and the paper (based on the readme) in the paper branch and re-compiled the paper. Could you let me know if the points are clarified or if I should invest more words into describing the context of the functions in the paper?

mabesa commented 1 year ago

Golly, sth went wrong with the changes in the paper.md (they don't appear in the pdf). I'm updating.

mabesa commented 1 year ago

Updated the paper text accordingly