computeDiurnalTemperatureCycle Function

Hi @mabesa,

There is no example for this computeDiurnalTemperatureCycle function. Without example, it could be hard to correctly use this function based on the function documentation below.

#' @param era5_data ERA5 csv-file (RS MINERVE Database input) with details on
#'   stations and hourly P,T and Q data.
#' @param param Parameter list with year_min and year_max fields that denote the
#'   period of interest for which the mean diurnal per-sttion cycles should be
#'   computed.

For example, the list for param argument should include 5 elements, but the documentation only mentioned 2 element (year_min and year_max). I tried an example using the demo data atbashy_glacier_demo_data/RSMINERVE/hist_obs_rsm.csv, assuming this is the correct one to use for era5_data.

data <- read.csv('../atbashy_glacier_demo_data/RSMINERVE/hist_obs_rsm.csv')
param_list <- list(year_min = 1990, year_max = 2000,
                   year_min_Baseline = 1979, year_max_Baseline = 2011,
                   station = 'Atbaschy_Midstream_Subbasin_5')
test <- computeDiurnalTemperatureCycle(era5_data = data,
                                       param = param_list)

Then got this error:

Error in `build_longer_spec()`:
! `cols` must select at least one column.
Run `rlang::last_error()` to see where the error occurred.
Warning message:
`type_convert()` only converts columns of type 'character'.
- `df` has no columns of type 'character'

It might be because I am using the wrong era5_data or param. It would be helpful to include an example in the instruction for this function. If that is difficult, please improve the documentation details for this function.

https://github.com/openjournals/joss-reviews/issues/4805

hydrosolutions / riversCentralAsia

computeDiurnalTemperatureCycle Function #122