search

hygieia / hygieia-scm-gitlab-collector

Hygieia Collector for Gitlab SCM
https://github.com/capitalone/Hygieia/blob/gh-pages/pages/hygieia/collectors/scm/gitlab.md
Apache License 2.0
4 stars 13 forks source link

Docker-related configuration has multiple issues #12

Open aquaraga opened 4 years ago

aquaraga commented 4 years ago

There are a couple of issues with the docker-related configuration, and in turn the dockerized hygieia-scm-gitlab-collector that is built using the current Dockerfile:

  1. Inconsistency of PROP_FILE location between properties-builder.sh and Dockerfile

    The PROP_FILE variable set in docker/properties-builder.sh is PROP_FILE=config/hygieia-gitlab-scm-collector.properties, and that's where the properties get generated on container start. However, the springboot app as per the Dockerfile looks at a different location for the properties file - i.e. in the Dockerfile, the PROP_FILE is specified this way: ENV PROP_FILE /hygieia/config/application.properties.

  2. Wrong variable commitThresholdDays set

    The docker/properties-builder.sh has a variable commitThresholdDays set, which is unused in the code. However, there seems to be a variable in GitlabSettings.java called firstRunHistoryDays which has not been set in docker/properties-builder.sh.

rvema commented 4 years ago

@aquaraga please few free to contribute back by submitting a PR