search

hygieia / hygieia-scm-gitlab-collector

Hygieia Collector for Gitlab SCM
https://github.com/capitalone/Hygieia/blob/gh-pages/pages/hygieia/collectors/scm/gitlab.md
Apache License 2.0
4 stars 13 forks source link

Reuse same env var as sonar collector docker properties builder #22

Closed yannschepens closed 4 years ago

yannschepens commented 4 years ago

In order to normalize env var for collectors. And remove useless MONGO_PORT env var, this not consistent and useless (my opinion)

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

:white_check_mark: paruff
:white_check_mark: Irvyne
:white_check_mark: rvema
:white_check_mark: yannschepens
:white_check_mark: aquaraga
:x: Courtney Peng

Courtney Peng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

rvema commented 4 years ago

@yannschepens please sign the CLA so that this change can be accepted

yannschepens commented 4 years ago

Damn I did an error, wait a second

rvema commented 4 years ago

Damn I did an error, wait a second

sure, let me know when you are ready

yannschepens commented 4 years ago

I gonna close this one (I tried to change the commiter, but unfortunatelly it changes more things that I though)

yannschepens commented 4 years ago

I can't sign the CLA with my professional mail address. Sorry

You can go to this one : https://github.com/Hygieia/hygieia-scm-gitlab-collector/pull/23 with my personal one.