Closed Redmega closed 6 years ago
When this is merged I will publish to the @next
tag so we can start testing on example sites w/o ruining anyones days.
Publishing this will mark the release of v1.0.0
It will be a breaking change since people (I know I am doing this myself) might be relying on our faulty way of getting the type name before (Post
became posts
singular)
If you can build a site with it I am happy to have you push to npm and try from there, local builds are error below but could be something I am doing.
https://app.netlify.com/sites/kokodokai/deploys/5aa1c954295b550a0ac6aa8c https://github.com/rdela/gatsby-graphcms-rd/tree/canary
vs a successful deploy
https://app.netlify.com/sites/kokodokai/deploys/5aa1976eefbe5d48095be0b4
so I would say it fails on onCreateNode: Artists
any idea why?
Do I have the wrong (non-)plural somewhere now?
Alright I'll test out on my local in an hour or so
So all the issues were caused by pluralization assumptions that were wrong.
Apparently, for a given type Artist
, its singular within gatsby graphql queries is artist
and its plural is allArtist
. This is read as "All of type Artist" which makes some kind of sense I guess...
:tada: This PR is included in version 0.1.0-next.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Adds a bunch of tests and fixes some pluralization issues