hygraph / gatsby-source-graphcms

The official Gatsby source plugin for GraphCMS projects
https://graphcms.com
MIT License
145 stars 41 forks source link

Set origin as an option #52

Closed senorgeno closed 6 years ago

senorgeno commented 6 years ago

I am able to make this plugin run with the SilverStripe CMS (https://www.silverstripe.com/), however it needs an Origin to be set in the headers.

Can we have this in the plugin?

Redmega commented 6 years ago

I don't see a problem with this, makes sense. I almost want to just put a generic headers prop, but it isn't out of control yet (and that would be a breaking change). @rdela thoughts?

senorgeno commented 6 years ago

Great @Redmega i have made the changes you've suggested. I like the idea of being able to set generic headers in the future. I am not familiar with circleci. Do I need to run this as part of the PR?

rdela commented 6 years ago

@senorgeno no circle will run on its own, I can take a look tomorrow

Redmega commented 6 years ago

Yeah, circle's not responding. Just something we have to look into.

Redmega commented 6 years ago

Ok tests seem to be fixed

Redmega commented 6 years ago

@senorgeno origin param added as part of 1.0.0-alpha.2. Thanks for your contributions! 🎉

senorgeno commented 6 years ago

Great, thanks!

On Wed, Jun 20, 2018 at 4:25 AM Angel J Piscola notifications@github.com wrote:

@senorgeno https://github.com/senorgeno origin param added as part of 1.0.0-alpha.2. Thanks for your contributions! 🎉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GraphCMS/gatsby-source-graphcms/pull/52#issuecomment-398460936, or mute the thread https://github.com/notifications/unsubscribe-auth/AAsd6BuTFqzT9J5VJOdpjobrCmy3QzkGks5t-SYVgaJpZM4UnHFI .

-- Gene Dower genedower@gmail.com

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 0.1.0-next.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: