hygraph / gatsby-source-graphcms

The official Gatsby source plugin for GraphCMS projects
https://graphcms.com
MIT License
145 stars 41 forks source link

.babelrc, babel plugins, building and index.js noop #6

Closed rdela closed 6 years ago

rdela commented 6 years ago

@redmega comment on #1 review:

Without the .babelrc we can't use stuff like spread operator or new feature imports or whatever... To the best of my knowledge, at least. Though I will say, I don't think we need babel-plugin-transform-runtime. Don't see it being used anywhere

@hmeissner in slack:

do we need this noop with plugin decoupled? https://github.com/GraphCMS/gatsby-source-graphcms/blob/master/index.js

Let’s get CircleCI set up (#4) and testing oldest active node LTS, 6.12.0, and use it as baseline so we are not sayin “dunno builds for me”

LTS schedule

Redmega commented 6 years ago

Let’s get CircleCI set up (#4) and testing oldest active node LTS, 6.12.0, and use it as baseline so we are not sayin “dunno builds for me”

We can get concurrent builds up for 6 and 8. Open source projects get three parallel containers

As far as the noop, that's a @kyleamathews question. I copied it from the other plugins. I believe it's because Gatsby uses the gatsby-node.js instead of the package main.

rdela commented 6 years ago

Word we are go for Circle setup you want to handle @Redmega or want me to?

rdela commented 6 years ago

Circle success on node 4 for experimentally remove babel-plugin-transform-runtime

builds 4 https://circleci.com/gh/rdela/gatsby-source-graphcms/8 6 https://circleci.com/gh/rdela/gatsby-source-graphcms/9 8 https://circleci.com/gh/rdela/gatsby-source-graphcms/10 9 https://circleci.com/gh/rdela/gatsby-source-graphcms/7

see also #4 🎉

rdela commented 6 years ago

Woohoo node 4 on Windows even! https://ci.appveyor.com/project/rdela/gatsby-source-graphcms/build/job/wlwvhf5g4sp3uw8j