search

hygraph / rich-text

A set of companion packages for Hygraph's Rich Text Field
MIT License
93 stars 18 forks source link

Anmol/ux 185 html ast plugin improvements for bandai #93

Closed anmolarora1 closed 2 years ago

anmolarora1 commented 2 years ago

https://linear.app/graphcms/issue/UX-185/html-ast-plugin-improvements-for-bandai

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 37b3d3292b4c7b31dd388e32c6ba9619571cc352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------------- | ----- | | @graphcms/html-to-slate-ast | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

linear[bot] commented 2 years ago
UX-185 HTML-AST plugin improvements for Bandai

Shaping Doc - [https://www.notion.so/graphcms/HTML-AST-plugin-improvement-for-Bandai-d19ab73d6c6542aba34ce797b5e70bc9](https://www.notion.so/graphcms/HTML-AST-plugin-improvement-for-Bandai-d19ab73d6c6542aba34ce797b5e70bc9) The issue at hand is that Bandai has several HTML elements that are not supported by the plugin. The two cases that we’re going to be solving are: 1. Importing iframes in hygraph. At the moment, iframes cannot be imported into Hygraph. 2. Importing elements inside tables. At the moment, when you import a table with bold text inside it, the text is not migrated as bold. ## Definition of done 1. Iframes - the task is considered done when a user is able to use the html-ast plugin to import an iframe element into the rich text field in Hygraph. The content of the iframe (e.g. a YouTube video) should be visible in the Rich Text field. A user should be able to play the video (or interact with a different element), change the iframe’s dimensions, and delete the iframe. The imported iframes should have a default appearance. 2. Bold text in tables - the task is considered done when a user is able to use the html-ast plugin to import a table with bold text, and the bold text remains bold in Hygraph’s rich text field.

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 5.27 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 5.21 KB (0%)
packages/html-renderer/dist/rich-text-html-renderer.cjs.production.min.js 2.71 KB (0%)
packages/html-renderer/dist/rich-text-html-renderer.esm.js 2.66 KB (0%)