search

hygraph / rich-text

A set of companion packages for Hygraph's Rich Text Field
MIT License
93 stars 18 forks source link

Update index.ts openInNewTab value #98

Closed internetdrew closed 1 year ago

internetdrew commented 1 year ago

When I use this in the same way the docs indicate it always results in '_self'. Looks like it's asking for the target value within the target itself, which will not be assigned and always return false.

Does this make sense or am I missing something? I figured by returning true, we just always have that value and if it's deconstructed and present, will make the ternary work properly.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 4e22681de9e57e012317f89ffab61ad985a30758

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR