search

hyj1991 / v8-profiler-next

node bindings for the v8 profiler
MIT License
219 stars 21 forks source link

Add typings for typescript support #12

Closed lukaskurz closed 4 years ago

lukaskurz commented 4 years ago

What I did

No changes to the source code, so everything should still work the same as before. I just created a index.d.ts file containing types for all the exposed functions and classes. I tried my best to understand the API and write the fitting types and jsdoc comments.

Motivation

I am planning to use this library in my project zakzak, where I use typescript. Since I would really like to have types when writing code, I thought I'd add them.

hyj1991 commented 4 years ago

cool pr~

lukaskurz commented 4 years ago

@hyj1991 Could you also update the npm package please :sweat_smile: so i can start using it in my lib, thank you very much.

hyj1991 commented 4 years ago

@lukaskurz v8-profiler-next@1.2.0 has been published, thx for this pr :)