search

hyj1991 / v8-profiler-next

node bindings for the v8 profiler
MIT License
218 stars 21 forks source link

Node.js v20 Release #65

Closed DJMcK closed 10 months ago

DJMcK commented 1 year ago

I see in fdedcbab1520d759e7595fdeddd3889401432081 from last week that the lib could now offer support Node v20.

The current release of v8-profiler-next (v1.9.0), is from prior to that commit.

It would be much appreciated if you can publish a new release which includes the Node v20 support.

Many thanks!

Apollon77 commented 1 year ago

We would be interested too

hyj1991 commented 1 year ago

Thanks for your feedback. I will be releasing a version soon that supports v20.x :)

mhuggins commented 1 year ago

Following. Thank you, looking forward to the release!

gchicoye commented 1 year ago

Hi, Couldn't agree more :):)

Thanks!

noahtallen commented 12 months ago

Hey @hyj1991, anything we can do to help move this release forward?

harjot-ct commented 11 months ago

For those looking for an interim solution, setting v8-profiler-next's version in package.json to https://github.com/hyj1991/v8-profiler-next#fdedcbab1520d759e7595fdeddd3889401432081 should work.

This will retrieve and build the package from GitHub instead, triggering the module to pack for the target platform with node-gyp correctly :)

harjot-ct commented 11 months ago

I did find that using node-gyp was fine locally, but really slowed down our CI/CD pipeline. I've published a fork package with the precompiled node binaries here: https://github.com/harjot-ct/v8-profiler-next/releases/tag/v1.10.0.

So, you can now install @harjot-ct/v8-profiler-next and it should not require node-gyp to build/install. Caveats are that I didn't produce any Windows builds, and only have an m1-compatible build for node 20!

gchicoye commented 10 months ago

Hi! Any news on that? Thanks a lot for this incredible job anyway!!!!

hyj1991 commented 10 months ago

Sorry for the late update, I've been busy with year-end activities. The new version v8-profiler-next@v1.10.0 is now released :)

See https://github.com/hyj1991/v8-profiler-next/commit/ba0b6b9c46b6469466da5e995b7cb4099de1a5c1.

Apollon77 commented 10 months ago

Wooohhohoooo ... thank you so much and happy 2024!