hyj1991 / v8-profiler-next

node bindings for the v8 profiler
MIT License
219 stars 21 forks source link

no template named 'is_lvalue_reference_v' in namespace 'std' #67

Closed malthe closed 10 months ago

malthe commented 11 months ago

Trying to install on Mac/ARM64 but getting:

npm ERR! In file included from ../src/cpu_profiler/cpu_profiler.cc:1:
npm ERR! In file included from ../src/cpu_profiler/cpu_profiler.h:4:
npm ERR! In file included from ../src/isolate_aware.h:4:
npm ERR! In file included from ../../nan/nan.h:62:
npm ERR! In file included from /Users/mborch/Library/Caches/node-gyp/21.3.0/include/node/node.h:73:
npm ERR! In file included from /Users/mborch/Library/Caches/node-gyp/21.3.0/include/node/v8.h:24:
npm ERR! In file included from /Users/mborch/Library/Caches/node-gyp/21.3.0/include/node/v8-array-buffer.h:13:
npm ERR! In file included from /Users/mborch/Library/Caches/node-gyp/21.3.0/include/node/v8-object.h:9:
npm ERR! /Users/mborch/Library/Caches/node-gyp/21.3.0/include/node/v8-maybe.h:106:45: error: no template named 'is_lvalue_reference_v' in namespace 'std'; did you mean 'is_lvalue_reference'?
npm ERR!   template <class U, std::enable_if_t<!std::is_lvalue_reference_v<U>>*>
npm ERR!                                        ~~~~~^~~~~~~~~~~~~~~~~~~~~
npm ERR!                                             is_lvalue_reference
npm ERR! /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__type_traits/is_reference.h:26:29: note: 'is_lvalue_reference' declared here
hyj1991 commented 10 months ago

This has been fixed in 'v1.10.0', just need to upgrade the nan version to resolve the issue.