hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.27k stars 96 forks source link

Python egg-info: should require colorama-0.4.6 #110

Closed slackingfred closed 1 year ago

slackingfred commented 1 year ago

Description

There are some Windows-specific code in main.py as follows:

# def run():
    # On Windows: Try to fix color rendering if not in git bash
    if IS_WINDOWS:
        import colorama
        colorama.just_fix_windows_console()

On my computer it complained about just_fix_windows_console not found.

It turned out that I had an outdated colorama package (0.4.4) installed. After running

pip install --user --upgrade colorama

hyfetch starts working okay.

The twist is, I just upgraded hyfetch using pip before encountering the issue. That means hyfetch is missing dependency.

TODO: update Python dependency file to include the required version of each external Python module referenced.

Neofetch version: hyfetch-1.4.7

Verbose log

PS C:\Users\bspub> hyfetch
Traceback (most recent call last):
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.2800.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\bspub\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\Scripts\hyfetch.exe\__main__.py", line 7, in <module>
  File "C:\Users\bspub\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\hyfetch\main.py", line 354, in run
    colorama.just_fix_windows_console()
AttributeError: module 'colorama' has no attribute 'just_fix_windows_console'
hykilpikonna commented 1 year ago

Thanks for bringing this up. Fixed!