hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.23k stars 96 forks source link

Add hyfetch to Homebrew #147

Closed osalbahr closed 1 year ago

osalbahr commented 1 year ago

Is your feature request related to a problem? Please describe.

Add hyfetch to Homebrew. This will simplify installing and keeping hyfetch up-to-date.

Describe the solution you'd like A clear and concise description of what you want to happen.

brew install hyfetch

And have both hyfetch and neowofetch installed. Ideally, I think it should also replace the current neofetch Homebrew formula.

Describe alternatives you've considered

Additional context

I’d like to be able to use neowofetch without having to mess with my Python environment (or having to make a venv).

osalbahr commented 1 year ago

From the Universal Install I am looking at the Makefile and noticed two things:

  1. It installs neofetch rather than neowofetch which might introduce a collision with the neofetch formula

This could be solved by marking hyfetch as conflicting with neofetch. Or, alternatively, add a make install-neowofetch. I think the first is better, since there's hardly a reason to want to have both installed.

  1. It doesn't install hyfetch

I don't know if using pip install in a Homebrew formula is allowed. What would it take to add a make install-all that installs both neofetch and hyfetch? Or, is there a better alternative to using make?

Side note: the artifacts for hyfetch would need to be added to https://github.com/dylanaraps/neofetch/archive/refs/tags/7.1.0.tar.gz if a make install-all is added.


Thoughts?

BKasin commented 1 year ago

I'm not very familiar with Homebrew's package system, but the alternative to pip would be python setup.py build and then python setup.py install --prefix=#{prefix}. That will build hyfetch, and then copy both it's binary and neofetch as neowofetch to $prefix/bin/. So if Azalea prefers to keep the Makefile as is, that is the change you would have to make in your Homebrew PR.

BKasin commented 1 year ago

hyfetch has been added to Homebrew as of this commit https://github.com/Homebrew/homebrew-core/commit/270dc19435c65e085ce7180c19e8816dace2365e

osalbahr commented 1 year ago

@BKasin thx!