Closed osalbahr closed 1 year ago
From the Universal Install I am looking at the Makefile and noticed two things:
neofetch
rather than neowofetch
which might introduce a collision with the neofetch formulaThis could be solved by marking hyfetch
as conflicting with neofetch
. Or, alternatively, add a make install-neowofetch
. I think the first is better, since there's hardly a reason to want to have both installed.
hyfetch
I don't know if using pip install
in a Homebrew formula is allowed. What would it take to add a make install-all
that installs both neofetch
and hyfetch
? Or, is there a better alternative to using make
?
Side note: the artifacts for hyfetch
would need to be added to https://github.com/dylanaraps/neofetch/archive/refs/tags/7.1.0.tar.gz if a make install-all
is added.
Thoughts?
I'm not very familiar with Homebrew's package system, but the alternative to pip
would be python setup.py build
and then python setup.py install --prefix=#{prefix}
. That will build hyfetch
, and then copy both it's binary and neofetch
as neowofetch
to $prefix/bin/. So if Azalea prefers to keep the Makefile as is, that is the change you would have to make in your Homebrew PR.
hyfetch has been added to Homebrew as of this commit https://github.com/Homebrew/homebrew-core/commit/270dc19435c65e085ce7180c19e8816dace2365e
@BKasin thx!
Is your feature request related to a problem? Please describe.
Add
hyfetch
to Homebrew. This will simplify installing and keepinghyfetch
up-to-date.Describe the solution you'd like A clear and concise description of what you want to happen.
And have both
hyfetch
andneowofetch
installed. Ideally, I think it should also replace the currentneofetch
Homebrew formula.Describe alternatives you've considered
Install using
pip
It works fine. But the problem comes with upgrading. Sincepip
doesn’t have a dependency resolver,pip -U --all
is not a thing. I’d also prefer to avoid messing with my Python environment.Use a venv It should work fine, if I add a symlink in
~/.local/bin
, keeping my system’s Python environment untouched. But the other points still remain.Additional context
I’d like to be able to use
neowofetch
without having to mess with my Python environment (or having to make a venv).