hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.3k stars 96 forks source link

use sed -r instead of -E when using GNU sed #171

Closed Un1q32 closed 1 year ago

Un1q32 commented 1 year ago

sed -r and -E do the same thing, but sed -E is the portable version that works with all versions of sed, however some old versions of GNU sed only support -r, a workaround is to check if we're running GNU sed, and use -r if we are

Un1q32 commented 1 year ago

bump

Un1q32 commented 1 year ago

@BKasin can you try the latest commit, I reworked it into a wrapper function that replaces the arguements if sed is GNU sed, should be completely transparent so nobody has to remember to add $sed_ext to every sed command from now on

catumin commented 1 year ago

Will do.

hykilpikonna commented 1 year ago

Nice fix, thanks!

And @BKasin thank you so much for the detailed testing!