hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.15k stars 90 forks source link

[Debian] hyfetch does not render logo in motd #224

Closed skibbipl closed 6 months ago

skibbipl commented 6 months ago

Describe the bug

I saw that hyfetch is packaged for debian so I decided to replace unmaintained neofetch. I have a motd script that displays neofetch banner after login. So I replaced neofetch with hyfetch, but moth displays only system info without the logo part.

Expected behavior

Logo displayed after logging in to system.

Screenshots

executing hyfetch from terminal image motd version image

Config file

Please paste the content of ~/.config/hyfetch.json below:

{
    "preset": "rainbow",
    "mode": "rgb",
    "light_dark": "dark",
    "lightness": 0.65,
    "color_align": {
        "mode": "horizontal",
        "custom_colors": [],
        "fore_back": null
    },
    "backend": "neofetch",
    "args": null,
    "distro": null,
    "pride_month_shown": [],
    "pride_month_disable": false
}

Additional context

It works fine with original neofetch.

BKasin commented 6 months ago

Apologies if my responses are slow for a bit, I'm working around family stuff for a few days.

Can you try setting args in the config to "-v", and piping the output of the motd to a file that you can upload? If not, I'll see if I can recreate this later today when I'm home.

skibbipl commented 6 months ago

I added the "-v" to the config but motd is not displaying debug information. I'm not sure how exactly motd executes the scripts in debian. It's some PAM magic and perhaps this causes the issue. However regular hyfetch displays following warnings:

root@rpi4b ~ # hyfetch
/usr/bin/neowofetch: eval: line 5319: unexpected EOF while looking for matching ``'
/usr/bin/neowofetch: eval: line 5319: unexpected EOF while looking for matching ``'
/usr/bin/neowofetch: line 5319: ,"   .    $$$ : command not found
/usr/bin/neowofetch: eval: line 5319: unexpected EOF while looking for matching `''
/usr/bin/neowofetch: eval: line 5319: unexpected EOF while looking for matching `''
/usr/bin/neowofetch: eval: line 5319: unexpected EOF while looking for matching `''
/usr/bin/neowofetch: eval: line 5319: unexpected EOF while looking for matching `''
                                  root@rpi4b
       _,met$$$$$gg.              ----------
    ,g$$$$$$$$$$$$$$$P.           OS: Debian GNU/Linux trixie/sid (trixie) aarch64
/usr/bin/neowofetch: line 1543: warning: command substitution: ignored null byte in input
 ,$$P'              `$$$.         Host: Raspberry Pi 4 Model B Rev 1.1
',$$P       ,ggs.     `$$b:       Kernel: 6.1.21-v8+
`d$$'     ,$P"'   .    $$$        Uptime: 27 days, 14 hours, 16 mins
 $$P      d$'     ,    $$P        Packages: 851 (dpkg)
 $$:      $$.   -    ,d$$'        Shell: zsh 5.9
 $$;      Y$b._   _,d$P'          Terminal: 2
 Y$$.    `.`"Y$$$$P"'             CPU: ARM Cortex-A72 (4) @ 1.50 GHz
/usr/bin/neowofetch: line 3296: glxinfo: command not found
  `Y$$                            Memory: 0.40 GiB / 3.70 GiB (11%)
   `Y$$.                          Network: 1 Gbps
     `$$b.
       `Y$$b.
          `"Y$b._
              `"\""

[!] Config: Sourced user config.    (/root/.config/neowofetch/config.conf)
[!] Info: Couldn't detect Editor.
[!] Info: Couldn't detect Resolution.
[!] Info: Couldn't detect DE.
[!] Info: Couldn't detect WM.
[!] Info: Couldn't detect WM Theme.
[!] Info: Couldn't detect Theme.
[!] Info: Couldn't detect Icons.
[!] Info: Couldn't detect Cursor.
[!] Info: Couldn't detect Terminal Font.
[!] Info: Couldn't detect GPU.
[!] Info: Couldn't detect Bluetooth.
[!] Info: Couldn't detect BIOS.
[!] Neowofetch command: /usr/bin/neowofetch --ascii --source /tmp/tmpbg2tg_bn/ascii.txt --ascii-colors -v
[!] Neowofetch version: 7.3.11
BKasin commented 6 months ago

The change causing that behavior is the stdout flag. Fix options are:

Set args in hyfetch.json to "--stdout=off"

Set $HOME/.config/neowofetch/config.conf to have stdout=off (for me it's the final option in the file).

skibbipl commented 6 months ago

Yeah, problem solved! Thanks.

BKasin commented 6 months ago

Glad I could help!

skibbipl commented 6 months ago

Perhaps this could be added to FAQ?

BKasin commented 6 months ago

Yeah, I'll add a section for it.