hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.15k stars 90 forks source link

Fix Git package download #229

Closed slackingfred closed 5 months ago

slackingfred commented 5 months ago

Description

On Windows, hyfetch offers to install a "minimal package for Git" if bash.exe is not found in Git's default installation path or %PATH%. However, this feature has two problems that prevent it from working.

This pull request fixes these by auto-creating the folder and downloading the full Git package instead, with corresponding change in output message.

TODO: It would be better to install a standalone version of MinGW Bash, instead of downloading a full Git only for the Bash.

Relevant Links

Screenshots

Before the fix (caused by nonexistent min_git): before

After the fix (working properly): after

Additional context

More problems exist with the (un)installation of hyfetch on Windows, especially when installing from Git or local directory instead of pypi. I'll open an issue for that.