search

hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.23k stars 96 forks source link

Flag Addition Request #30

Open sapsicle opened 1 year ago

sapsicle commented 1 year ago

Description

Add demisexual flag please.

hykilpikonna commented 1 year ago

Thank you for the request. I would be happy to add the demisexual flag, but the current framework of displaying colors wouldn't allow hyfetch to display the triangle at the left.

↓ image

The current framework stores flags as a list of colors, which means that it can only display flags that are made of horizontal/vertical lines. This is definitely a design mistake and a bad assumption I made early in the project's development.

image

I want to restructure the framework to be compatible with all flags, but it would be very difficult since the entire code base was implemented around this bad assumption. A lot of code needs to change, and I currently don't have time to redesign the framework because of my midterm exams and papers.

If anyone has any suggestions on creating the new framework, feel free to comment or create a pull request. If not, I'll try redesigning the project when I have time.

LilyIsTrans commented 1 year ago

I've got an idea for a framework for arbitrary flags based on storing them as functions/callable things that take an x and y coordinate normalized between 0 and 1, and return a colour. That way, literally any potential arrangement of colours in a 2D rectangle could be represented. I'm not sure if it's feasible for me to go through and change everything myself, but I'll give it a shot and if it seems to work I'll make a PR.