hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.15k stars 90 forks source link

Hyfetch shows my Macs as Hackintosh but Neofetch don't #310

Closed AirLiz closed 1 week ago

AirLiz commented 2 weeks ago

Describe the bug

When i open Hyfetch it shows my Mac in the host as a hackintosh but it's an Apple branded machine, it's running OpenCore Legacy Patcher so probably it's the reason. The problem is in Neofetch it shows as a Host: MacBookPro9,2 but on Hyfetch it shows Host: Hackintosh (SMBIOS: MacBookPro9,2), isn't an important issue but i want solve it

Expected behavior

I expected the host section show "MacBookPro9,2" but it shows "Hackintosh (SMBIOS: MacBookPro9,2)"

Screenshots

Screenshot 2024-06-16 at 16 06 27 Screenshot 2024-06-16 at 16 06 32

Config file

conf.txt

Verbose log

neofetch.log

Additional context

I tried on a iMac14,3 (iMac 21,5" Late 2013) and happens the same thing

hykilpikonna commented 1 week ago

HyFetch currently detects hackintosh when either FakeSMC, VirtualSMC, or Lilu kext exists, and neofetch is similar except it doesn't detect Lilu. These are fundamental kexts that all hackintosh systems have. The detection for Lilu was introduced in https://github.com/dylanaraps/neofetch/pull/2005 for detecting hackintosh VMs (since virtual machines don't require kext-level SMC simulation). Tho, I guess Lilu is also used in OCLP, and most hackintosh VMs don't require Lilu either, so I guess I will remove Lilu detection.

image