luna-1024
commented
2 weeks ago Hey there!
I am a NixOS user as well and also want to be able to color the logo like you have proposed. I am taking the time to work on a generalized approach that would improve many distros' logos. It might make sense to go with my approach instead.
Regardless of what I have been working on, here's some feedback on your PR:
When adding a logo, only modify neofetch. The auto-generated code in hyfetch/distros and docs will be generated in the release process. See this recent PR as an example. Note that it modifies the docs but probably did not need to.
As it stands, there are generally only small and old variants of logos. We should decide if the documentation should document colorful variants of logo(s) as well.
And here's my thoughts on logo coloring:
I think it would be great if more colorful "segmented" logos would be easily accessible by the user. If we add a colored version as a new entry, the user would have to look into the options/manual/source to discover it exists. Perhaps only a fraction of users will do that, as many may not even consider the possibility variants exist. If we can get the colorful logo to users by default, it would be awesome to have a lot more colorful NixOS (and other distro) segmented logos common in screenshots out in the wild!
The configuration UI could be improved as well since the randomized rolling system would take a lot of rolls to get the rainbow colors in the correct order.
For now, I have already have a small-ish change prepared for backwards compatibility for direct modifications to a logo where nothing is changed but having more colorable areas/segments. If it is accepted, we could directly modify the NixOS logo as you have it after that code is in. That results in functional parity with your change, and should be achievable fairly quickly. Then NixOS users setting up their hyfetch would have 6 separately colored lambdas by default. (As well for any other distros we improve the coloring)
I would like to hear your thoughts on this approach! As well from @hykilpikonna
Description
Adding another option for NixOS to set all colors separately.
Screenshots