Brightness doesnt work

[TheArcaneBrony]

Description

Brightness does not seem to work under kitty, which supports 24bit color.

• [?] Does this issue still occur in the master branch? (Required if issue) (no idea, i'm running the hyfetch package off the AUR, which is currently using the 1.4.5 tag)

Neofetch version

Screenshot

Config file

n/a, this is firstrun

Verbose log

1. Run neofetch -vv 2> neofetchlog
2. Upload the contents of neofetchlog to pastebin, gist or equivalent.

[TheArcaneBrony]

This screenshot is with brightness set to 30%: You would expect it to be darker. With the current brightness, I'm unable to make out the colors almost at all.

[hykilpikonna]

The brightness control was designed to adjust the colors for light/dark-themed backgrounds so that the colors are visible, so I limited it so that it can only dim on light backgrounds and only lighten on dark backgrounds.

For example, since you're using a light background, each individual color would not be lightened above its original lightness value. The reverse is true, if you're using a dark background, each color would not be dimmed below its original value.

You can't see the lightening on 🏳️‍⚧️ because the colors are already very bright. However, you can see the lightening for a darker preset on a dark background (e.g. rainbow):

As another example, you can only see dimming with a bright preset on a white background:

With that said, if you REALLY want to dim colors on a dark background, you can manually edit ~/.config/hyfetch.json and change "light_dark": "dark" to "light_dark": "light"

[TheArcaneBrony]

What I was aiming for was more contrast, actually

[Kaiddd]

@hykilpikonna this should probably be closed since it's a non issue (quite a few of these can be closed)

[hykilpikonna]

@hykilpikonna this should probably be closed since it's a non issue (quite a few of these can be closed)

Okay closing now