hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.34k stars 114 forks source link

Brightness doesnt work #57

Closed TheArcaneBrony closed 1 year ago

TheArcaneBrony commented 1 year ago

Description

Brightness does not seem to work under kitty, which supports 24bit color.

Neofetch version

Screenshot

image

Config file

n/a, this is firstrun

Verbose log

  1. Run neofetch -vv 2> neofetchlog
  2. Upload the contents of neofetchlog to pastebin, gist or equivalent.
TheArcaneBrony commented 1 year ago

This screenshot is with brightness set to 30%: image You would expect it to be darker. With the current brightness, I'm unable to make out the colors almost at all.

hykilpikonna commented 1 year ago

The brightness control was designed to adjust the colors for light/dark-themed backgrounds so that the colors are visible, so I limited it so that it can only dim on light backgrounds and only lighten on dark backgrounds.

For example, since you're using a light background, each individual color would not be lightened above its original lightness value. The reverse is true, if you're using a dark background, each color would not be dimmed below its original value.

You can't see the lightening on 🏳️‍⚧️ because the colors are already very bright. However, you can see the lightening for a darker preset on a dark background (e.g. rainbow):

image

As another example, you can only see dimming with a bright preset on a white background:

image

With that said, if you REALLY want to dim colors on a dark background, you can manually edit ~/.config/hyfetch.json and change "light_dark": "dark" to "light_dark": "light"

TheArcaneBrony commented 1 year ago

What I was aiming for was more contrast, actually

Kaiddd commented 1 year ago

@hykilpikonna this should probably be closed since it's a non issue (quite a few of these can be closed)

hykilpikonna commented 1 year ago

@hykilpikonna this should probably be closed since it's a non issue (quite a few of these can be closed)

Okay closing now