hyfetch installed by pip does not recognize Git for Windows installed by scoop

hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!

MIT License

1.23k stars 96 forks source link

hyfetch installed by pip does not recognize Git for Windows installed by scoop #83

Closed Namorzyny closed 1 year ago

Namorzyny commented 1 year ago

Description

Because of hard coded path of Git for Windows, hyfetch can not recognize other situations like the portable version or a custom installation path, or as the title says.

https://github.com/hykilpikonna/hyfetch/blob/2fda11455206c9605a989f076d8a724ada6fec03/hyfetch/neofetch_util.py#L154

[x] Does this issue still occur in the master branch? (Required if issue)

Neofetch version

7.3.6

hykilpikonna commented 1 year ago

This is fixed by #87

teohhanhui commented 1 month ago

In the process of porting the Python code to Rust (#317), I've found that 5c34876c538cede13ffe8bf21275151b7259a511 has reintroduced this bug?

The paths used to find bash are hardcoded again... But I understand that we can't try to find bash.exe in PATH too thanks to #233 :crying_cat_face: