hykilpikonna / hyfetch

🏳️‍🌈 🏳️‍⚧️ Neofetch with LGBTQ+ pride flags!
MIT License
1.23k stars 96 forks source link

Sometimes, flag stripes are obscured because the OS logo is missing lines #85

Open pandaninjas opened 1 year ago

pandaninjas commented 1 year ago

Description

The pink part of the flag gets obscured because the ascii Zorin OS logo doesn't have any characters in those lines. image

hykilpikonna commented 1 year ago

Thanks for reporting the issue! In this specific case for Zorin, you can use a vertical alignment instead (you can use hyfetch -c to reconfigure the color alignment)

image

As for a general fix, I honestly don't know how this can be effectively fixed programmatically without a lot of manual edge cases, but I'm happy to accept any ideas!

pandaninjas commented 1 year ago

Thanks for reporting the issue! In this specific case for Zorin, you can use a vertical alignment instead (you can use hyfetch -c to reconfigure the color alignment)

image

As for a general fix, I honestly don't know how this can be effectively fixed programmatically without a lot of manual edge cases, but I'm happy to accept any ideas!

A general fix might be to discount empty lines for flag calculations. However, it might make the flag look weird