search

hylo-lang / Swifty-LLVM

Swifty interface for the LLVM compiler infrastructure.
Apache License 2.0
28 stars 5 forks source link

Improve test coverage #57

Closed kyouko-taiga closed 6 months ago

kyouko-taiga commented 7 months ago

This PR adds a test exercising the standard optimization passes of LLVM (i.e., -O0, -O1, ...)

dabrahams commented 7 months ago

👍

dabrahams commented 7 months ago

I guess you're not yet testing locally with an assert-enabled LLVM. We strongly recommend that, y'know ;-)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.70%. Comparing base (35e5838) to head (4e0ad45). Report is 15 commits behind head on lifetime-enforcement.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## lifetime-enforcement #57 +/- ## ========================================================= - Coverage 85.78% 67.70% -18.09% ========================================================= Files 14 30 +16 Lines 197 709 +512 ========================================================= + Hits 169 480 +311 - Misses 28 229 +201 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dabrahams commented 6 months ago

@kyouko-taiga Currently it shows ArrayType.count to be uncovered, but resolving the merge might make that go away.

dabrahams commented 6 months ago

@kyouko-taiga oh, the base branch is not main. Don't know whether you realized that.

kyouko-taiga commented 6 months ago

I think that was intentional, because IIRC the code my additional test is building on that other PR and is an answer to your comment.

kyouko-taiga commented 6 months ago

Since I closed #55 I will salvage this PR to make it work with the "current" API design.