Closed jorgezreik closed 1 year ago
Love this repo, incredible job with it! I think it has a ton of potential.
If you're accepting community contributions, I could open a PR to fix this myself. Lmk what you think!
height doesn't use default values in the same way width does.
height
width
Taken from the online demo
Input:
* { width: 2rem; height: 2rem; }
Output:
w-8 h-[2rem]
The height configuration has no reference to default values:
val => (isUnit(val) ? `h-${getUnitMetacharactersVal(val, [CustomSelect.vw]) || `[${val}]`}` : '')
On the other hand, the width configuration does:
val => (isUnit(val) ? `w-${(useAllDefaultValues && getRemDefaultVal(val)) || getUnitMetacharactersVal(val, [CustomSelect.vh]) || `[${val}]`}` : '')
Thus, I believe we can fix this issue by using the useAllDefaultValues function in the height configuration as well.
useAllDefaultValues
You are right, it is now fixed, and subsequently if you find new problems, you can create PR directly if you wish, thank you for providing the problem
Love this repo, incredible job with it! I think it has a ton of potential.
If you're accepting community contributions, I could open a PR to fix this myself. Lmk what you think!
Issue
height
doesn't use default values in the same waywidth
does.Reproduction
Input:
Output:
Possible Cause
The
height
configuration has no reference to default values:On the other hand, the
width
configuration does:Thus, I believe we can fix this issue by using the
useAllDefaultValues
function in the height configuration as well.