hymm / squid-tracks

An Unofficial Desktop Client for Splatnet2
135 stars 25 forks source link

Consider switching to electron-webpack #9

Closed hymm closed 7 years ago

hymm commented 7 years ago

Use electron-webpack instead of create-react-app to build application.

https://github.com/electron-userland/electron-webpack

hymm commented 7 years ago

Right now create-react-app is a little awkward in that babel is not used for the main process. It only works on the renderer process. Besides that window.require is causing jest to fail tests. Electron-webpack looks like it might be a good starting point for getting the typical webpack functions like HMR and babel.

Should probably do more research into other alternatives.

hymm commented 7 years ago

also consider https://github.com/timarney/react-app-rewired

hymm commented 7 years ago

using react-app-rewired now and updated some other tooling, but couldn't get babel working on main process. Closing issue for now.