search

hymns-for-worship / issues

Hymns for worship issue tracker
3 stars 1 forks source link

Added fuzzy search on all lists, should help with this case! #120

Open ebizman opened 2 months ago

ebizman commented 2 months ago

Added fuzzy search on all lists, should help with this case!

Originally posted by @rodydavis in https://github.com/hymns-for-worship/issues/issues/28#issuecomment-1462389970

Still not working - main search bar does not return any hymns for any text search. Text search should hit title, scripture, topic, etc fields and return a matching list of hymns.

rodydavis commented 2 months ago

Can you upload a video? It was working for me

ebizman commented 2 months ago

I probably can download a screencap app but this is real simple - type any term, return and then nothing: -RhettOn Aug 14, 2024, at 4:34 PM, Rody Davis @.***> wrote: Can you upload a video? It was working for me

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

ebizman commented 2 months ago

Ok, this must be a bug as I closed the app and then opened it again and tried and now search is working. Only thing I was doing in the app was building some lists

rodydavis commented 2 months ago

Sounds good, so just need to do some smoke tests then to see what gets it in that state

ebizman commented 2 months ago

Search for SKU is still not working:

image image
rodydavis commented 2 months ago

Since the SKU is the number I would suggest using an explicit filter till it rolls out

image

ebizman commented 2 months ago

Searching for SKU using a filter against the Number field also does not work:

[image: image.png]

On Sat, Aug 24, 2024 at 8:10 AM Rody Davis @.***> wrote:

Since the SKU is the number I would suggest using an explicit filter till it rolls out

81BDE461-4656-409F-BB25-3ED53441AD5B.jpeg (view on web) https://github.com/user-attachments/assets/96e07b8b-26ce-4aff-8bfe-a17d164f9b22

— Reply to this email directly, view it on GitHub https://github.com/hymns-for-worship/issues/issues/120#issuecomment-2308391077, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMKFLUIW7ZHCNW5WVAW7QLZTCA4PAVCNFSM6AAAAABMRAVWOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGM4TCMBXG4 . You are receiving this because you authored the thread.Message ID: @.***>

rodydavis commented 2 months ago

Image is not loaded, you need to attach on GitHub directly on the issue.

But I was meaning searching the number part of the SKU since it is the number:

RJSEC1002 -> 1002

Then you can do an exact number search. Most users will not need to search by SKU but happy to still add it if it helps.

ebizman commented 2 months ago

Oh, ok.  I misunderstood - thought you had enabled full text search against all fields.  -RhettOn Aug 24, 2024, at 8:22 AM, Rody Davis @.***> wrote: Image is not loaded, you need to attach on GitHub directly on the issue. But I was meaning searching the number part of the SKU since it is the number: RJSEC1002 -> 1002 Then you can do an exact number search. Most users will not need to search by SKU but happy to still add it if it helps.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

rodydavis commented 2 months ago

It's full text search on all fields but the app does not display the SKU so I only return the fields relevant to the app.

So the number of id would be the way to search for a hymn if you have an exact value.

Also using a filter will give much better results if you are trying to be specific. The full text search is really more for lyrics and topics and getting better results there.