search

hynek / build-and-inspect-python-package

Build and Inspect Python Packages in GitHub Actions
MIT License
181 stars 13 forks source link

FEAT - Allow user to change artefacts name (packages) #92

Closed trallard closed 8 months ago

trallard commented 8 months ago

eFirst, thanks for creating this super nifty action 🚀 I have found it extremely helpful.

Now, to the feature request.

I have been using this action in a repository with two packages (for various reasons). Both are currently built, inspected, and released within the same workflow (which also builds then some Docker images).

With the v4 of actions/upload-artifact, multiple uploads to the same Artifact are no longer possible. Since this action hardcodes the name within Upload built artifacts step which makes it impossible to use for multiple packages in the same workflow.

It seems this would need some changes so that it allows for the user to customise this to allow them to upload multiple artefacts (see example https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact)

with:
  name: packages-${{ matrix.runs-on }} # or whatever

This might be niche, but if it sounds like a good improvement, I would happily send a PR to add this feature. If not, I will remain in v1 for now.