Implement loading DH parameters.

hynek / pem

PEM file parsing in Python.

https://pem.readthedocs.io/

MIT License

159 stars 37 forks source link

Implement loading DH parameters. #21

Closed mithrandi closed 8 years ago

mithrandi commented 8 years ago

Fixes #18.

hynek commented 8 years ago

[ ] changelog entry
[x] docs

mithrandi commented 8 years ago

Done! :smile: (I can't check the fancy checkboxes, I guess because I don't have perms to edit your post :sob:)

hynek commented 8 years ago

Given what I wrote above we have new fancy boxes :):

[x] if dhParameters is passed it should take precedence
[x] if dhParameters is passed a DeprecationWarning should be raised
[ ] the deprecation needs to be documented in the CHANGELOG.
[x] the deprecation needs to be tested for.

mithrandi commented 8 years ago

Okay, done. I just made the two tests for that code path check for the deprecation warning in addition to verifying the functionality; a separate test seemed a bit redundant. Let me know if you want me to tweak the wording any.

hynek commented 8 years ago

oh and by the changelog/deprecation I meant a

Deprecations:
^^^^^^^^^^^^^

section like in 15.0.0 btw

hynek commented 8 years ago

(between backward incompatible changes and changes)

mithrandi commented 8 years ago

Aha! Fixed.