hynek / pem

PEM file parsing in Python.
https://pem.readthedocs.io/
MIT License
159 stars 37 forks source link

Add support for parsing certificate requests. #29

Closed vpelletier closed 7 years ago

vpelletier commented 7 years ago

Support both "old" (NEW CERTIFICATE REQUEST) and "normal" (CERTIFICATE REQUEST) captions.

codecov[bot] commented 7 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         128    129    +1     
  Branches       23     23           
=====================================
+ Hits          128    129    +1
Impacted Files Coverage Δ
src/pem/__init__.py 100% <ø> (ø) :arrow_up:
src/pem/_core.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4bd156...b6baea1. Read the comment docs.

vpelletier commented 7 years ago

Test failure looks unrelated to this PR:

setup.py:44:1: E305 expected 2 blank lines after class or function definition, found 1
hynek commented 7 years ago

hi thanks for the PR, I’ve fixed the flake8 in master so you should be able to rebase.

The changes look straight-forward enough, but the new class needs to be added to https://raw.githubusercontent.com/hynek/pem/master/docs/api.rst

thanks!

vpelletier commented 7 years ago

Thanks for pointing api.rst out, I missed it. I rebased & amended my commit.

hynek commented 7 years ago

Thanks!

hynek commented 7 years ago

FYI, since I have no real TODOs, I’ve release a 17.1 with just your change: https://pypi.org/project/pem/

vpelletier commented 7 years ago

Thanks for the release ! Now my project only needs to wait for the next cryptography release and all dependencies will be available on pypi.