hynek / pem

PEM file parsing in Python.
https://pem.readthedocs.io/
MIT License
156 stars 37 forks source link

Initial support for DSA private keys. #49

Closed adiroiban closed 3 years ago

adiroiban commented 3 years ago

Scope

This adds support for loading DSA private keys in legacy OpenSSH PEM format.

I was not able to find the RFC in which the format is defined.

I named it DSAPrivateKey and not OpenSSHDSAPrivateKey as you can also generate it using OpenSSL.

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

hynek commented 3 years ago

Thanks! I'll tweak the changelog a bit but I didn't want to do a review round around it.