This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.
[x] Added tests for changed code.
[x] Updated documentation for changed code.
[x] New functions/classes have to be added to docs/api.rst by hand.
[x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecateddirectives.
Find the appropriate next version in our __init__.py file.
[NA] Documentation in .rst files is written using semantic newlines.
[x] Changes (and possible deprecations) are documented in the changelog.
Scope
Fixes: #28
This is just the initial implementation for a trusted certificate.
No extra handling is done to compare a normal certificate with its associated trusted certificate
The OpenSSL is included in the name of the class as this is an OpenSSL only feature. See https://github.com/hynek/pem/issues/28#issuecomment-804096684
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.
docs/api.rst
by hand.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in our__init__.py
file..rst
files is written using semantic newlines.