support \r\n new lines - Githubissues

hynek / pem

PEM file parsing in Python.

https://pem.readthedocs.io/

MIT License

159 stars 37 forks source link

support \r\n new lines #7

Closed Raz0r closed 9 years ago

Raz0r commented 9 years ago

This will help to correctly parse files with \r\n as new lines.

hynek commented 9 years ago

Wouldn’t \r? be more idiomatic? The change will also require a test that it really works with \r\n.

I’ve fixed the Travis failure, so could you also rebase on master please?

Thanks!

coveralls commented 9 years ago

Coverage remained the same when pulling f7f2307f7c98f8dc62a067d7f73169cb109689b2 on Raz0r:patch-1 into 6d54824e985f3c32f09b86f5d6eb867fe224ffff on hynek:master.

coveralls commented 9 years ago

Coverage remained the same when pulling f7f2307f7c98f8dc62a067d7f73169cb109689b2 on Raz0r:patch-1 into 6d54824e985f3c32f09b86f5d6eb867fe224ffff on hynek:master.

Raz0r commented 9 years ago

Changed to \r?, rebased on master, but Travis keeps failing (Twisted package checksum under pypy does not match, that's weird). I will bother to write a test if I have time.

hynek commented 9 years ago

fixed in d175ebf7b31eaf9dc917bb10e0d8cde2dcb5df34